Switch session by left/right swipe #452
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Tested on 8.0, rebased against master, seems to work 👍 |
Author
|
I've been using this for a year, and found one issue: when selecting a text, a cursor move can be interpreted as a swipe. This should be easy to fix (check if we are in selection mode, and disable swipe detection), but this was not on top of my list due to lack of interest for this PR from the maintainer. |
|
Is it still alive? |
Member
|
@asavonic, if you make the swipe fix, I will help you get this in, as I think it's a worthwhile feature addition. |
|
Ping -- much wanted feature |
Cypher1
approved these changes
Nov 14, 2020
|
@asavonic Any chance the swipe fix could be implemented? Even just having a fling to change session would be a huge usability improvement for me. |
Author
|
Let me check if I can still build the project. |
|
Any luck? 😁 |
105a19a to
b950efe
Compare
21804bc to
3f7a939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added gesture detection for horizontal swipe. Swipe right would switch session forward, swipe left to switch backward.
Feature request #48.
Tested on Android 5.0.