这是indexloc提供的服务，不要输入任何密码
Skip to content

ci(attach_debug_apks_to_release): delete release on failure to build/upload #3241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2023
Merged

ci(attach_debug_apks_to_release): delete release on failure to build/upload #3241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85b84b9
ci(attach_debug_apks_to_release): delete release on failure to
thunder-coding Feb 8, 2023
1eb0912
ci: print error for assembleDebug again
thunder-coding Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/workflows/attach_debug_apks_to_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ jobs:
echo "Building APKs for 'APK_VERSION_TAG' release"
export TERMUX_APK_VERSION_TAG="$APK_VERSION_TAG" # Used by app/build.gradle
export TERMUX_PACKAGE_VARIANT="${{ env.PACKAGE_VARIANT }}" # Used by app/build.gradle
./gradlew assembleDebug
if ! ./gradlew assembleDebug; then
echo "Build failed for '$APK_VERSION_TAG' release."
exit 1
fi

echo "Validating APKs"
for abi in universal arm64-v8a armeabi-v7a x86_64 x86; do
Expand Down Expand Up @@ -71,3 +74,13 @@ jobs:
release_name:
tag: ${{ github.event.release.tag_name }}
checksums: sha256,sha512,md5
delete_release:
if: failure()
runs-on: ubuntu-latest
needs: [build, upload]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
steps:
- name: Delete release (if other job(s) failed)
Copy link
Member

@agnostic-apollo agnostic-apollo Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need (if...). Otherwise, looks fine. Will have to test these changes and verify hashes when I make the release.

Copy link
Member Author

@thunder-coding thunder-coding Feb 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it just in case so that anyone just wondering through logs does not wonder why someone would want to delete release on create_release.

Copy link
Member Author

@thunder-coding thunder-coding Feb 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And about the checksums, they are correct as per my knowledge. I had checked them when moving to our fork for termux/termux-packages' bootstrap archives uploads.

Also I had tested the CI by running it on my fork as a test. https://github.com/thunder-coding/termux-app/releases/tag/v0.118.5 (The test release). https://github.com/thunder-coding/termux-app/actions/runs/4124697065 (Respective CI run)

Copy link
Member

@agnostic-apollo agnostic-apollo Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it just in case so that anyone

if: failure() would have made it clear too, but okay.

And about the checksums, they are correct as per my knowledge. I had checked them when moving to our fork for termux/termux-packages' bootstrap archives uploads.

Your checksum files don't follow the standard sha256sum and md5sum formats and so automated validation would fail.

https://superuser.com/questions/1566136/is-the-sha256-file-format-formally-defined-somewhere-how-should-it-be-parsed

Its also adding apt-android-*/ before filenames, which is also wrong, there is no directory structure in the release itself. It would exist because you are first uploading the apks to github artifacts and then downloading them again, which has the apt-android-* artifacts, so again automated validation would fail since files won't be found and users would have to add additional checks for which subdirectory the files are expected to be under.

The old way directly uploaded the apks to release and didn't have any artifacts. Also the uppercase CHECKSUMS looks ugly, ideally it should be something like release.sha256 with a standard extension, old way is not adding the extension either.

I also didn't deliberately add md5sum support previously, since its not really secure and should not be used for security related purposes.

https://en.wikipedia.org/wiki/MD5#Security

https://github.com/termux/termux-app/actions/runs/1669634446

https://github.com/termux/termux-app/releases/tag/v0.118.0

  • sha256sum
3141295849db07a1f4c919ee67a261df723a8ff751b990b87d663a6457b81a2c  termux-app_v0.118.0+github-debug_universal.apk
10b412fa0aca5a4585c367a446f8e63525bdc9a7b8dfce2d3f84c2f148e19e21  termux-app_v0.118.0+github-debug_arm64-v8a.apk
84f1d108c1bfb8aed3c0f61253b778ca1d6dfbb2deec2a7f8d1ab89b2c9c7a52  termux-app_v0.118.0+github-debug_armeabi-v7a.apk
90c1e62bcede3897cf097d179658f08340d5adde84d50bfae7af056d6dd6c32e  termux-app_v0.118.0+github-debug_x86_64.apk
a5cbc3aea8c199c4db5fbc3697ad8e92117d354ada845a03713e000950a8574f  termux-app_v0.118.0+github-debug_x86.apk

https://github.com/thunder-coding/termux-app/actions/runs/4124697065

https://github.com/thunder-coding/termux-app/releases/tag/v0.118.5

  • CHECKSUMS-sha256.txt
apt-android-5/termux-app_v0.118.5+apt-android-5-github-debug_arm64-v8a.apk	da60a58853f34e8f8d3f6e9ff0c1482a34349cee8362e988d5d66bc58564c87f
apt-android-5/termux-app_v0.118.5+apt-android-5-github-debug_armeabi-v7a.apk	13c3d506025498b55b59c76cbefd4dca23aaf7db2aef64ab31eabb433230437f
apt-android-5/termux-app_v0.118.5+apt-android-5-github-debug_universal.apk	7564a28dd1186186d47ae2d04d5a39ba8b84a831d4fb726556aded284958b302
apt-android-5/termux-app_v0.118.5+apt-android-5-github-debug_x86_64.apk	1883c777ddabfa36457aad88c1e0c572012d71339c9a4dcd6a048dab28957e5d
apt-android-5/termux-app_v0.118.5+apt-android-5-github-debug_x86.apk	de7bb2fc355de0f6cd183af87e331ef82954ff7d4dabc1ecb38bd44f33ed014b
apt-android-7/termux-app_v0.118.5+apt-android-7-github-debug_arm64-v8a.apk	c2ee76c4af5c78f7f8132860fdca55c2ff87bf7af2acff1b8017644171094ef9
apt-android-7/termux-app_v0.118.5+apt-android-7-github-debug_armeabi-v7a.apk	92abcedc592ca59ef0baeb89bae919db771555d434d9328a7bd7dd84eb3701e6
apt-android-7/termux-app_v0.118.5+apt-android-7-github-debug_universal.apk	95bd25fab12fcb11174d96cd75dccdfc9e04300c3fdc3f416d7a3ac92cd76f58
apt-android-7/termux-app_v0.118.5+apt-android-7-github-debug_x86_64.apk	b28d7a00341a4811fa5439769ebc5e893cbcf5547ced8c8e8846e3135716c6ed
apt-android-7/termux-app_v0.118.5+apt-android-7-github-debug_x86.apk	366427cc6b59df76b2ee578b6143efd88fbe28630d645b0e790c4e51b5aa2c75
  • CHECKSUMS-md5.txt
apt-android-5/termux-app_v0.118.5+apt-android-5-github-debug_arm64-v8a.apk	d69abede860f42994cffd55303290ca1
apt-android-5/termux-app_v0.118.5+apt-android-5-github-debug_armeabi-v7a.apk	2b424d20e62ba0cc42beb7e0e2ad845c
apt-android-5/termux-app_v0.118.5+apt-android-5-github-debug_universal.apk	344be1bdf4a6e4302eab8eb85372850e
apt-android-5/termux-app_v0.118.5+apt-android-5-github-debug_x86_64.apk	11ea381736ba19785a67adf4f4f44122
apt-android-5/termux-app_v0.118.5+apt-android-5-github-debug_x86.apk	caddd2a5b4ae42021d00eb7a35d39b22
apt-android-7/termux-app_v0.118.5+apt-android-7-github-debug_arm64-v8a.apk	941ed23c678bc045f12ea40b547d30e0
apt-android-7/termux-app_v0.118.5+apt-android-7-github-debug_armeabi-v7a.apk	159317799c52328c217a2fb0207485b6
apt-android-7/termux-app_v0.118.5+apt-android-7-github-debug_universal.apk	3ddfaac1fe22339cb1538a7dca231e0f
apt-android-7/termux-app_v0.118.5+apt-android-7-github-debug_x86_64.apk	4409b42f2852615a5f7911d90d5aedfe
apt-android-7/termux-app_v0.118.5+apt-android-7-github-debug_x86.apk	ffb801db9c43ed8e8fc008f74f4c8b33

run: |
gh release delete ${{ github.events.release.tag_name }}