Make it possible to target sdk 34 #3622
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c798c6 to
38408d4
Compare
catuhana
reviewed
Oct 5, 2023
Co-authored-by: tuhana <github@tuhana.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are changes which makes it possible to set
targetSdk=34, and still start up a successful terminal session on an Android 34 device.We don't bump the targetSdk yet, as that would require the termux/termux-exec-package#24 to be present for Android 10+ devices to successfully execute files in the session. But this is one step closer (and should be able to merge after merging #3619, which will make the build work, since this requires a newer android gradle plugin version - hence why this PR has a draft status).
Description of changes:
android:foregroundServiceType="specialUse", and the associated<uses-permission android:name="android.permission.FOREGROUND_SERVICE_SPECIAL_USE" />, to fulfil the Foreground service types are required requirement.Targeting S+ requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.