Make TerminalRenderer public #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to use the renderer with a custom canvas without having to render to an Android View which requires a context and all sorts of stuff. Can't currently do that because the renderer is package-private
Member
|
Thanks! The TerminalRenderer class needs some love and cleanup, but having it public doesn't do any harm and allows projects such as yours to experiment with it. |
Contributor
Author
|
Thanks! I'm kinda new to android development, how can I configure my build.gradle to load this version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use the renderer with a custom canvas without having to render to an Android View which requires a context and all sorts of stuff.
Can't currently do that because the renderer is package-private.
The goal is to be able to render this onto a texture in Unity so that people can easily make stuff with termux in VR.