Implement full screen and add FullScreenWorkAround to fix ExtraKeysView #1911
Conversation
not displaying properly and inconsistently between various devices
|
Just curious: is there a way to have only one workaround suitable for all devices? Having different solutions for different device types selectable from the config is kinda weird. |
|
Ya between the various devices I tested there was inconsistent behavior in the way usable view space was being calculated with extra keys + status bar. Not sure why that is, so a WIP solution for now, but ideally it would "just work" for all devices w/o needing to specify that. |
|
@dkramer95 ConnectBot provides a similar widget (extra keys) for its terminal. Not sure if it has same issue as Termux extra keys, but if not, I guess it would be worth to check its implementation. |
* Use WindowInsetsListener to get nav bar height and use that
instead for calculating adjusted height for extra keys view
|
@xeffyr I have found a more reliable method that should eliminate the need for the other custom workarounds.. I found that I needed to use nav bar height and that was what was different between the different devices I had.. Tested new fix on each device and seems to work for all of them! |
There was a problem hiding this comment.
In summary:
- This can be merged, but I guess "fullscreen workaround" should be always enabled.
- Further work on this topic is needed.
Confirmed that it works on Samsung Galaxy S7 with workaround enabled. But there are issues:
- Blank status bar is present until touch keyboard was hidden.
- Property changes do not take effect on
termux-reload-settings.
On Pixel 5 things are even worse. Status bar is just made black without disappearing. See screenshot and notice big black bar on the top. Other apps using fullscreen are working properly.
|
@xeffyr I tested this on a Pixel 4 emulator and was able to replicate.. I tried experimenting w/ various flag combinations but didn't have much success... Closest I was able to get was this, but the content is still obscured by the status bar.. I could never get it to display in this position and have the status bar text go away.. All other attempts, status bar text would be hidden, but it would have that blank margin at the top. I'm sure some combo of flags exists to satisfy everything, but haven't found it yet :D. |
FullScreen Mode
Addresses: #507
Just setting full screen flag causes issue w/ ExtraKeysView:
FullScreenWorkAroundclass was added to help fix issues across various devices so that ExtraKeysView displays properly:Example of
termux.propertiesconfig for full screen w/ work-around:fullscreen-workaround-method = 1tested w/ Pixel (Emulator)fullscreen-workaround-method = 2tested w/ Samsung S7 and OnePlus 6Tfullscreen-workaround-method = 3tested w/ Sony Xperia XZSome trial and error may be needed for your device.. Another workaround may be needed if the above do not work.
Feedback and testing appreciated!