@xeffyr

Should TMPDIR clean up be performed after stopForeground()?

Also, can you make it clean its canonical file instead so that it also works when e.g. PREFIX is a symlink?

@fornwall

What's the point of the finishIfRunning loops? It wouldn't kill the "orphan" processes anyway.

Also, in the two ocassions where stopSelf() is called conditionally, one checks whether there's any background task while one does not, why is that? (In other words, why shouldn't removeTermSession() just call updateNotification() unconditionally?)

In addition, why should stopSelf() be called unconditionally for ACTION_STOP_SERVICE? (especially when onDestroy() doesn't deal with background tasks)

Should TMPDIR clean up be performed after stopForeground()?

Is there some benefits in doing it after stopForeground() ?
I think that all manipulations with $PREFIX should be done before anything else in onDestroy().

Also, can you make it clean its canonical file instead so that it also works when e.g. PREFIX is a symlink?

Yes, will do.

This is being part of the v0.71 which is now rolling out on Google Play.

@xeffyr I just thought perhaps stopForeground() is responsible for killing all the processes.

stopForeground() is responsible for killing all the processes.

It just removes Service from foreground state. It doesn't kill any processes.