Set orientation of HandleView in show #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8577e15 to
106ba7f
Compare
Previously, the long press menu would cover the first line of the selection.
When the selection handle changes direction, the selection jumps to the new point of the handle. When the handle changes direction at the same place when you come from the left as from the right, that makes it impossible to select the characters which are at the position where it changes direction. With this change the handle remains pointing towards the edge further into the line when you drag it from the edge and against the center.
When you hold down on a word that starts or ends at the edge of the screen, the handle will appear outside of the screen. This happens because the orientation was only switched when the handle is dragged, so when it is shown it just used the same orientation as it had for the last selection. Relates to termux#334, but not sure if it fixes it completely.
106ba7f to
caea889
Compare
trygveaa
commented
Mar 1, 2020
AdamMickiewich
pushed a commit
to VolyaTeam/dzida-app
that referenced
this pull request
Aug 8, 2022
* Place long press menu above selection Previously, the long press menu would cover the first line of the selection. * Flip selection handle at different positions depending on drag direction When the selection handle changes direction, the selection jumps to the new point of the handle. When the handle changes direction at the same place when you come from the left as from the right, that makes it impossible to select the characters which are at the position where it changes direction. With this change the handle remains pointing towards the edge further into the line when you drag it from the edge and against the center. * Set orientation of HandleView when showing it When you hold down on a word that starts or ends at the edge of the screen, the handle will appear outside of the screen. This happens because the orientation was only switched when the handle is dragged, so when it is shown it just used the same orientation as it had for the last selection. Relates to termux#334, but not sure if it fixes it completely.
contourintegrals
pushed a commit
to reisxd/termux-app
that referenced
this pull request
Oct 20, 2022
* Place long press menu above selection Previously, the long press menu would cover the first line of the selection. * Flip selection handle at different positions depending on drag direction When the selection handle changes direction, the selection jumps to the new point of the handle. When the handle changes direction at the same place when you come from the left as from the right, that makes it impossible to select the characters which are at the position where it changes direction. With this change the handle remains pointing towards the edge further into the line when you drag it from the edge and against the center. * Set orientation of HandleView when showing it When you hold down on a word that starts or ends at the edge of the screen, the handle will appear outside of the screen. This happens because the orientation was only switched when the handle is dragged, so when it is shown it just used the same orientation as it had for the last selection. Relates to termux#334, but not sure if it fixes it completely.
This was referenced Mar 26, 2025
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you hold down on a word that starts or ends at the edge of the
screen, the handle will appear outside of the screen. This happens
because the orientation was only switched when the handle is dragged, so
when it is shown it just used the same orientation as it had for the
last selection.
Relates to #334, but not sure if it fixes it completely.
Before:
After:
This is when holding down on the word "Working".