Prevent kill by Samsung Dex on plug/unplug. #1446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks a lot! This is included in version 0.90 of the app, which has now been released and should be available as an update shortly. |
|
Thank you very much @jeansch, you've just saved me 1 minute for each of my coffee pause return 😃 |
|
Yo are the best! Tested on SM Note 10+ , works like a charm =) |
trygveaa
reviewed
Feb 29, 2020
| android:label="@string/application_name" | ||
| android:configChanges="keyboard|keyboardHidden|orientation|screenSize" | ||
| android:label="@string/application_name" | ||
| android:configChanges="orientation|screenSize|smallestScreenSize|density|screenLayout|uiMode|keyboard|keyboardHidden|navigation" |
Contributor
Contributor
Author
There was a problem hiding this comment.
Hi, I don't know, I don't have much knowledge in android development. I just followed documentation link from #1259.
I don't use the S10 anymore. I would suggest to give it a try, then PR if needed.
Contributor
There was a problem hiding this comment.
Ah, so copied from Samsungs documentation, okay. Unfortunately, it doesn't seem like Samsung has documented why it is specified, and I don't have any Samsung devices, so I can't test if it breaks if I remove it. But I suppose the uiMode might change when you plug/unplug, so it has to be there.
|
I also have problem
…On Feb 27, 2021 8:48 PM, "Jerry Obot" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/src/main/AndroidManifest.xml
<#1446 (comment)>:
> @@ -31,11 +31,11 @@
<activity
android:name="com.termux.app.TermuxActivity"
- ***@***.***/application_name"
- android:configChanges="keyboard|keyboardHidden|orientation|screenSize"
+ ***@***.***/application_name"
+ android:configChanges="orientation|screenSize|smallestScreenSize|density|screenLayout|uiMode|keyboard|keyboardHidden|navigation"
Hi, I don't know, I don't have much knowledge in android development. I
just followed documentation link from #1259
<#1259>.
I don't use the S10 anymore. I would suggest to give it a try, then PR if
needed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1446 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS2ZX54P2TYJMDR6EEXRN5TTAU4ZNANCNFSM4KMX42ZA>
.
|
agnostic-apollo
added a commit
that referenced
this pull request
Jan 22, 2022
With this commit, activities will automatically change theme between day/night if `night-mode` `termux.properties` is not set or is set to `system` without requiring app restart. Dialog theming will be fully added in a later commit and may currently be in an inconsistent state or have crashes. The `uiMode` has been removed from `configChanges` of `TermuxActivity`, this may cause termux app to restart if samsung DEX mode is changed, if it does, then users should report it so that it can be fixed by re-adding the value and ignoring the change inside `TermuxActivity.onConfigurationChanged()`. The docs don't state if its necessary. Check related pull request #1446. Running `termux-reload-settings` will also restart `TermuxActivity`, the activity data should be preserved.
agnostic-apollo
added a commit
that referenced
this pull request
Jan 22, 2022
With this commit, activities will automatically change theme between day/night if `night-mode` `termux.properties` is not set or is set to `system` without requiring app restart. Dialog theming will be fully added in a later commit and may currently be in an inconsistent state or have crashes. The `uiMode` has been removed from `configChanges` of `TermuxActivity`, this may cause termux app to restart if samsung DEX mode is changed, if it does, then users should report it so that it can be fixed by re-adding the value and ignoring the change inside `TermuxActivity.onConfigurationChanged()`. The docs don't state if its necessary. Check related pull request #1446. Running `termux-reload-settings` will also restart `TermuxActivity`, the activity data should be preserved.
Peter-Feng-32
pushed a commit
to Peter-Feng-32/Termux-HWD
that referenced
this pull request
Mar 9, 2022
With this commit, activities will automatically change theme between day/night if `night-mode` `termux.properties` is not set or is set to `system` without requiring app restart. Dialog theming will be fully added in a later commit and may currently be in an inconsistent state or have crashes. The `uiMode` has been removed from `configChanges` of `TermuxActivity`, this may cause termux app to restart if samsung DEX mode is changed, if it does, then users should report it so that it can be fixed by re-adding the value and ignoring the change inside `TermuxActivity.onConfigurationChanged()`. The docs don't state if its necessary. Check related pull request termux#1446. Running `termux-reload-settings` will also restart `TermuxActivity`, the activity data should be preserved.
AdamMickiewich
pushed a commit
to VolyaTeam/dzida-app
that referenced
this pull request
Aug 8, 2022
With this commit, activities will automatically change theme between day/night if `night-mode` `termux.properties` is not set or is set to `system` without requiring app restart. Dialog theming will be fully added in a later commit and may currently be in an inconsistent state or have crashes. The `uiMode` has been removed from `configChanges` of `TermuxActivity`, this may cause termux app to restart if samsung DEX mode is changed, if it does, then users should report it so that it can be fixed by re-adding the value and ignoring the change inside `TermuxActivity.onConfigurationChanged()`. The docs don't state if its necessary. Check related pull request termux#1446. Running `termux-reload-settings` will also restart `TermuxActivity`, the activity data should be preserved.
contourintegrals
pushed a commit
to reisxd/termux-app
that referenced
this pull request
Oct 20, 2022
With this commit, activities will automatically change theme between day/night if `night-mode` `termux.properties` is not set or is set to `system` without requiring app restart. Dialog theming will be fully added in a later commit and may currently be in an inconsistent state or have crashes. The `uiMode` has been removed from `configChanges` of `TermuxActivity`, this may cause termux app to restart if samsung DEX mode is changed, if it does, then users should report it so that it can be fixed by re-adding the value and ignoring the change inside `TermuxActivity.onConfigurationChanged()`. The docs don't state if its necessary. Check related pull request termux#1446. Running `termux-reload-settings` will also restart `TermuxActivity`, the activity data should be preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1259
Tested on my device (Samsung S10)
Documentation here: https://developer.samsung.com/samsung-dex/modify-optimizing