Clear LineWrap flag when clearing lines using blockSet. #2971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you provide before and after screenshots showing the issue? |
Contributor
Author
|
Start, 1920x1080 screen, terminal size: 27x40. Note that the 5th and 7th line are wrapped: Results of ls before increasing fonts: Current master: After increasing fonts, 5th and 7th lines spaces wrapped to 6th and 8th lines respectively. With this commit (after the same process): display as expected. |
Member
|
Yeah, I can confirm that there is an issue. |
21804bc to
3f7a939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resets a row's mLineWrapped flag, if the last column is cleared with spaces.
Without this the flag remains from a previous line after clearing, for example on escape sequence
\e[2J.To see the bug:
clear ; ls /ctrl+alt+=to increase font size.Notice that the some of the ls lines are now not left aligned.