-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Fixed: Remove from recent apps on app close #2941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Reasonable, but that will need to be added as a |
|
While working on this I noticed that the app exits with finishAndRemoveTask if the back button is pressed. Should this be the case as pressing the back button is a less extreme exit than the terminal itself exiting? Apologies for the large screenshot. |
|
You have added it in preferences, not in properties like mentioned above. Termux user settings must all go in
You should check with A key like |
|
I've added it to properties and undone the other changes. At present, the back button calls finishAndRemoveTask no matter how many sessions remain. This seems wrong. Some better options are:
But this looks like a separate issue, I'll create a separate issue and pull request. |
What happens when it set?Current state in the screenshot below, the recent processes are on the left. Termux was finished here and also to the right where a SSH session on the same device that was also ended after the |
The key variable name and function name must match the key name.
That goes in https://github.com/termux/termux-tools/blob/master/termux.properties
Following should likely work from a quick look. There might be other cases as well that may need to be looked into.
It is not a separate issue, you created the issue in this pull request with the feature add and any issues should be fixed here and feature properly implemented before it can be merged. And there should be no merge commits in pull requests. |
This comment was marked as off-topic.
This comment was marked as off-topic.
21804bc to
3f7a939
Compare
|
I just noticed that syncthing has added code to remove it from recent tasks upon exit, which made me happy. The other “persistentish” app where I always have to manually kill it from the recent tasks list to avoid accidentally restarting it is termux, so I came to suggest the same. Glad someone is already working on it! Much appreciated. @Rillian-Grant, are you going to see this through code review? |
This change removes finished terminal sessions from the recent apps view.