Changed: RunCommandService Refactored #2810
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dService.java` Change 0xFF607D8B to GRAY
In function `onStartCommand()`, It's too long(about 200 lines). So extract the methods and reduce it to 58 lines. Extract theses -> `getCanonicalPath()`,`checkSymlink()`,`checkInvalidWorkingDirectory()`,`startTermuxService()`, `checkInvalidFile()`,`checkExecutable()`,`checkInvalidAppPolicy()`,`createExecutionIntent()`, `getSomeExecutionCommand()`,`checkInvalidAction()`,`replaceComma2Char()`,`checkRunner()`.
| TermuxPluginUtils.processPluginExecutionCommandError(this, LOG_TAG, executionCommand, false); | ||
| return stopService(); | ||
| } | ||
| Integer invalidRunner = checkRunner(intent, executionCommand); |
Member
There was a problem hiding this comment.
Could just return false from function and do
if(!checkRunner()) return stopService()
Member
|
Also the |
Author
|
@agnostic-apollo |
Member
|
Apart from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: RunCommandService Refactored