fix: Top value of text action bar content rect #2801
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dev-bz Not working anymore |
|
Could anyone please approve this PR's workflow so that the dev can test it? |
Member
|
Workflow already ran. Pull requests will be merged after I push local changes depending on priority. https://github.com/termux/termux-app/actions/runs/2984933190/jobs/4940380176 |
21804bc to
3f7a939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle is draw from text's baseline, will keep content's bottom = baseline + handle.height, but content's top should = baseline + font's ascent.
Before
Small font:
The selection range is occluded
Large font:
Bar is away from the selection range
After
Small font size
Large font size