PhotoAPI: Take sensor orientation into account. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a Nexus 5X, the old code would take pictures that were upside-down. Apparently, the Android device standards require that the long edge of the sensor must align with the long edge of the device, but doesn't say which of the two ways to satisfy this manufacturers should pick. This change makes PhotoAPI generate right-side-up pictures in both conditions. Tested on a Nexus 7 (second-gen) and a Nexus 5X.
fornwall
added a commit
that referenced
this pull request
Nov 29, 2015
PhotoAPI: Take sensor orientation into account
Member
|
Nice work! Will test it later, but your testing seems to be enough so will release an updated version (0.7) of Termux:API which will be available in Google Play in a couple of hours. |
Contributor
Author
|
I'm sorry; I never thanked you for merging this. Thank you for accepting my change, and thank you for making this awesome project open-source. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a Nexus 5X, the old code would take pictures that were upside-down.
Apparently, the Android device standards require that the long edge of the
sensor must align with the long edge of the device, but doesn't say which of the
two ways to satisfy this manufacturers should pick. This change makes PhotoAPI
generate right-side-up pictures in both conditions.
Tested on a Nexus 7 (second-gen) and a Nexus 5X.