NotificationAPI: Dark mode support for icons #535
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also skip iterating over remaining icons if we already found the right one
The sound option is being ignored in favor of channel settings. Instead, add a silent option to be able to create notifications without playing any sound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the black notification icons were shown on a dark background if system-wide dark mode was enabled. (At least in some cases, there are differences between vendors and android versions)
To make them more visible, apply a white tint while termux is in dark mode.
The second commit fixes an issue I had with the latest build from GH Actions (df3cb50) where the first notification action supplied after a reboot overwrote all subsequent ones.
Tested on a Huawei Mate 20 Pro with
Android 10
EMUI 12
Termux 0.118.0+1488bb0