Add dual-sim feature #491
Merged
Add dual-sim feature #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please aprove it now ;) |
Grimler91
requested changes
Feb 21, 2022
Member
Grimler91
left a comment
There was a problem hiding this comment.
Thanks for the PR, looks reasonable!
See comment about spelling.
| int dateIndex = cur.getColumnIndex(CallLog.Calls.DATE); | ||
| int durationIndex = cur.getColumnIndex(CallLog.Calls.DURATION); | ||
| int callTypeIndex = cur.getColumnIndex(CallLog.Calls.TYPE); | ||
| int simTypeIndex = cur.getColumnIndex(Callog.Calls.PHONE_ACCOUNT_ID); |
Member
There was a problem hiding this comment.
Should probably be
CallLog.Calls.PHONE_ACCOUNT_ID
instead of
Callog.Calls.PHONE_ACCOUNT_ID
Contributor
Author
There was a problem hiding this comment.
Yes, you're right. Sorry for the mix-up.
Grimler91
approved these changes
Feb 23, 2022
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.