这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(call-log): Fix query call log raise Exception #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix(call-log): Fix query call log raise Exception #440

wants to merge 2 commits into from

Conversation

@KunoiSayami
Copy link

@KunoiSayami KunoiSayami commented Aug 23, 2021

@KunoiSayami KunoiSayami marked this pull request as ready for review August 23, 2021 15:39
@thunder-coding
Copy link
Member

thunder-coding commented Oct 28, 2021

I have no idea how this works, probably you can review this @Grimler91

@ghost
Copy link

ghost commented Oct 28, 2021

There is a number of identical statements under if block for APIs >= Build.VERSION_CODES.O and others. I guess it would be better to refactor code in way that would allow reuse them and keep under conditional only parts that differ.

@KunoiSayami
Copy link
Author

KunoiSayami commented Oct 28, 2021

I guess it would be better to refactor code in way that would allow reuse them and keep under conditional only parts that differ.

I tried by I failed, maybe you will have a better way to refactor it

@Grimler91
Copy link
Member

Grimler91 commented Nov 21, 2021

The offset parameter doesn't work with this implementation, and there is an issue with the sort descending arg:

11-21 14:15:43.872  9470  9510 W Bundle  : Attempt to cast generated internal exception:
11-21 14:15:43.872  9470  9510 W Bundle  : java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.String
11-21 14:15:43.872  9470  9510 W Bundle  : 	at android.os.BaseBundle.getString(BaseBundle.java:1199)
11-21 14:15:43.872  9470  9510 W Bundle  : 	at android.content.ContentProvider.query(ContentProvider.java:1470)
11-21 14:15:43.872  9470  9510 W Bundle  : 	at android.content.ContentProvider$Transport.query(ContentProvider.java:278)
11-21 14:15:43.872  9470  9510 W Bundle  : 	at android.content.ContentProviderNative.onTransact(ContentProviderNative.java:106)
11-21 14:15:43.872  9470  9510 W Bundle  : 	at android.os.Binder.execTransactInternal(Binder.java:1159)
11-21 14:15:43.872  9470  9510 W Bundle  : 	at android.os.Binder.execTransact(Binder.java:1123)

For the latter, maybe QUERY_ARG_SORT_COLUMNS should be used instead of QUERY_ARG_SQL_SORT_ORDER.

I've played around with it but haven't managed to solve the offset issue, yet

@andremarcais andremarcais mentioned this pull request Apr 22, 2022
Open
@Benjamin-Loison Benjamin-Loison mentioned this pull request Aug 25, 2024
Open
@agnostic-apollo
Copy link
Member

agnostic-apollo commented Jan 21, 2025

Closed by 11eff56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Grimler91 Grimler91 Awaiting requested review from Grimler91

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

termux-call-log doesn't work

4 participants

@KunoiSayami @thunder-coding @Grimler91 @agnostic-apollo