-
Notifications
You must be signed in to change notification settings - Fork 659
AudioAPI: avoid redundant code #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks! |
|
Why i didn't write it this way in the first place What i think is happening is that the same code compiles differently at different api levels. |
|
It won't compile... i was in a hurry.
On 24 Mar. 2018 9:50 am, "tomty89" <notifications@github.com> wrote:
No, it's just because (if I am not missing anything else) bs is defined in
the if. Should be fine if we take it out.
Btw why all the finals?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#134 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AP-Ot8P-6B2llS3zDLQF1vuSKBbEJN3Eks5thXwfgaJpZM4R-y3K>
.
|
|
Wait a second is the error you posted build time error or runtime error (that seen only on older device)? Does it change anything if you keep the structure but just change |
|
build time |
Not sure if it's the best way coz it still looks a bit stupid to me, but at least it should work for now. |
|
Sorry for not doing a build test before making the PR btw. Don't have a PC and didn't thought of testing it like this on Termux. |
No description provided.