AudioAPI: updates for AudioTrack methods #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several changes in the commit: 1. Use instance methods to get sample rate and buffer size info on Android N or above only instead of Android M, since both AudioAttributes.FLAG_LOW_LATENCY (256) and the implicitly used AudioFormat.SAMPLE_RATE_UNSPECIFIED (0) are available only since API 24 (N). 2. Use setPerformanceMode() on Android O, as FLAG_LOW_LATENCY is deprecated since API 26 (O). 3. Create AudioTrack instance of both the fast (LOW_LATENCY) and deep buffer (POWER_SAVING) mixer path. The two paths can be using different subdevices on different rate and buffer size (or same subdevice on same rate but different buffer size). For example on my phone: AUDIOTRACK_SAMPLE_RATE: 192000 AUDIOTRACK_BUFFER_SIZE_IN_FRAMES: 23046 AUDIOTRACK_SAMPLE_RATE_LOW_LATENCY: 48000 AUDIOTRACK_BUFFER_SIZE_IN_FRAMES_LOW_LATENCY: 192 4. Get info on sample rate with the getNativeOutputSampleRate() static method (static in Java's sense; the value is still sink- based) on builds older than N only. The rate appears to be of the fast (LOW_LATENCY) mixer path if it is available. 5. A note on the static method getMinBufferSize(). The reason it is not used even for older devices is, it returns buffer size info of the deep buffer (POWER_SAVING) mixer path, while NOSR is the rate of the fast (LOW_LATENCY) mixer path, so the value we can get with it is not always sensical.
Contributor
Author
|
Build test has been done on Termux: |
Member
|
Nice! This is now available in the newly released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several changes in the commit:
Use instance methods to get sample rate and buffer size info
on Android N or above only instead of Android M, since both
AudioAttributes.FLAG_LOW_LATENCY (256) and the implicitly used
AudioFormat.SAMPLE_RATE_UNSPECIFIED (0) are available only since
API 24 (N).
Use setPerformanceMode() on Android O, as FLAG_LOW_LATENCY is
deprecated since API 26 (O).
Create AudioTrack instance of both the fast (LOW_LATENCY) and
deep buffer (POWER_SAVING) mixer path. The two paths can be using
different subdevices on different rate and buffer size (or same
subdevice on same rate but different buffer size). For example on
my phone:
AUDIOTRACK_SAMPLE_RATE: 192000
AUDIOTRACK_BUFFER_SIZE_IN_FRAMES: 23046
AUDIOTRACK_SAMPLE_RATE_LOW_LATENCY: 48000
AUDIOTRACK_BUFFER_SIZE_IN_FRAMES_LOW_LATENCY: 192
Get info on sample rate with the getNativeOutputSampleRate()
static method (static in Java's sense; the value is still sink-
based) on builds older than N only. The rate appears to be of the
fast (LOW_LATENCY) mixer path if it is available.
A note on the static method getMinBufferSize(). The reason it
is not used even for older devices is, it returns buffer size info
of the deep buffer (POWER_SAVING) mixer path, while NOSR is the
rate of the fast (LOW_LATENCY) mixer path, so the value we can get
with it is not always sensical.