这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix inadvertent torch state toggling on some devices #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix inadvertent torch state toggling on some devices #202

wants to merge 1 commit into from

Conversation

@dkramer95
Copy link
Contributor

@dkramer95 dkramer95 commented Jul 29, 2018

Fixes #201

@dkramer95 dkramer95 mentioned this pull request Jul 29, 2018
Open
@tomty89
Copy link
Contributor

tomty89 commented Jul 30, 2018

Wouldn't this just make termux-torch off a no-op?

@dkramer95
Copy link
Contributor Author

dkramer95 commented Jul 30, 2018

@tomty89 termux-torch off is still used to turn off the LED only if it is on currently, otherwise it doesn't anything. Termux-Torch isn't a "true toggle" that automatically goes between states, the user is still responsible for specifying on or off... However, it could be implemented to be that way. Since this PR stores the state, it could be used to determine if the LED should be on or not.

@tomty89
Copy link
Contributor

tomty89 commented Jul 30, 2018 •
edited
Loading

What I mean is isEnabled would be set to false every time the API is called?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkramer95 @tomty89