Change alert-once to alert-always #83
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, editing a notification creates no alert, so alert-once had no effect. Changed to flag alert-always that sets alert-once to false if present.
Fixes 'unrecognized option: led-color' errors (Unable to test; led and vibration have never worked for me [Android 9; EMUI 9.1.0])
Contributor
|
Hey, Regarding the second commit and the missing comma, that's also a nice catch! |
Contributor
|
Merged the second commit. Closing. |
xalexalex
added a commit
to termux/termux-api
that referenced
this pull request
Aug 25, 2019
Because the default should be false, and in termux-api-package the --alert-once flag can be used to set it to true. Thanks to AgentConDier for spotting this. Fixes termux/termux-api-package#83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, editing a notification creates no alert, so alert-once had no effect. Changed to flag alert-always that sets alert-once to false if present. (Defaults to true in https://github.com/termux/termux-api/blob/master/app/src/main/java/com/termux/api/NotificationAPI.java#L80)