fix termux-media-player #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This was referenced Apr 6, 2018
Member
|
Thanks! This is now available in the updated version 0.27 of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes termux/termux-api#149 and replaces termux/termux-api#152 and #10
@fornwall @dkramer95 @landfillbaby
There are many deliberate changes from the original script because it didn't make sense. For one we don't need or want a pattern check because there are way more possible extension, and extension does not guarantee anything anyway. I notice that the java part has similar check which should be removed as well.
Also removed wrong infomation from usage, for example. We can play files under com.termux as well, and whether /sdcard is available is not specific to this.
Inquiries are welcomed for other changes if there are doubts.