Fix: Remove dangling reference to ExperimentalTFLiteToTosaBytecode #97508
+1
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the NameError encountered when calling . The underlying C++ symbol was removed in TensorFlow 2.19, but the Python helper remained, leading to a dangling reference. This change replaces the function definition with a to provide clearer feedback to users that the function is no longer available. Fixes: #88053
This commit removes the trailing blank lines in that were causing a syntax error in the CI/CD pipeline. This is a follow-up to the previous commit that removed the function. Fixes: #88053
| ordered_input_arrays, | ||
| ordered_output_arrays, | ||
| ) | ||
| return ExperimentalWriteBytecode(filename.encode('utf-8'), mlir_txt.encode()) |
There was a problem hiding this comment.
This line should not change. Please configure your editor to insert a newline at the end.
Suggested change
| return ExperimentalWriteBytecode(filename.encode('utf-8'), mlir_txt.encode()) | |
| return ExperimentalWriteBytecode(filename.encode('utf-8'), mlir_txt.encode()) | |
| return ExperimentalWriteBytecode(filename.encode('utf-8'), mlir_txt.encode()) | ||
|
|
||
|
|
||
| def experimental_tflite_to_tosa_bytecode( |
There was a problem hiding this comment.
You should also check where this function is being called and remove that too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Team
This addresses the NameError encountered when calling ExperimentalTFLiteToTosaBytecode(). The underlying C++ symbol was removed in TensorFlow 2.19 but the Python helper remained leading to a dangling reference. Merged PR #83174 This change replaces the function definition with a to provide clearer feedback to users that the function is no longer available.
Fixes: #88053