这是indexloc提供的服务，不要输入任何密码
Skip to content

[StableHLO<->HLO] Remove special handling for AddOp to Xor for booleans #97451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
+3 −31
Merged

[StableHLO<->HLO] Remove special handling for AddOp to Xor for booleans #97451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 2 additions & 30 deletions third_party/xla/xla/hlo/translate/mhlo_to_hlo/mlir_hlo_to_hlo.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5319,33 +5319,6 @@ LogicalResult ConvertInfeedtLayout(mlir::Operation* op,
return success();
}

// MHLO and XLA HLO disagree on the meaning of addition of `pred` / `i1`, so
// there has to be a special case somewhere to account for the difference. To
// get the expected behavior of an `AddOp` on `i1`, we have to use `xor`. Since
// the majority of the conversion is generated code, we just sidestep it here
// for this single case, and inline the code to emit an `xor`.
LogicalResult ExportXlaOperatorWrapped(mlir::Operation* inst,
OpLoweringContext ctx) {
auto op = dyn_cast<mlir::mhlo::AddOp>(inst);
if (op && mlir::cast<mlir::TensorType>(op.getResult().getType())
.getElementType()
.isSignlessInteger(1)) {
auto& value_map = *ctx.values;
auto result = op.getResult();
xla::XlaOp xla_arg_0;
if (failed(GetXlaOp(op.getLhs(), value_map, &xla_arg_0, op)))
return mlir::failure();
xla::XlaOp xla_arg_1;
if (failed(GetXlaOp(op.getRhs(), value_map, &xla_arg_1, op)))
return mlir::failure();
auto xla_result = xla::Xor(Unwrap(xla_arg_0), Unwrap(xla_arg_1));
value_map[result] = xla_result;
return mlir::success();
}

return ExportXlaOperator(inst, ctx);
}

LogicalResult ConvertToHloModule::PropagateLayouts(
const MlirToHloConversionOptions& options, mlir::Operation* inst,
xla::XlaOp xla_op) {
Expand Down Expand Up @@ -5702,9 +5675,8 @@ LogicalResult ConvertToHloModule::Lower(

*return_value = xla::XlaOp();

if (succeeded(ExportXlaOperatorWrapped(
inst,
{value_lowering, this, builder, &stack_frame_indexes_builder_}))) {
if (succeeded(ExportXlaOperator(inst, {value_lowering, this, builder,
&stack_frame_indexes_builder_}))) {
if (inst->getNumResults() == 1) {
auto iter = value_lowering->find(inst->getResult(0));
if (iter == value_lowering->end()) {
Expand Down
2 changes: 1 addition & 1 deletion third_party/xla/xla/hlo/translate/mhlo_to_hlo/tests/export.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func.func @main(%arg0: tensor<2xi1>) -> tensor<2xi1> {

// CHECK: ENTRY
// CHECK: %[[ARG:.*]] = pred[2] parameter(0)
// CHECK: ROOT %[[RESULT:.*]] = pred[2] xor(%[[ARG]], %[[ARG]])
// CHECK: ROOT %[[RESULT:.*]] = pred[2] add(%[[ARG]], %[[ARG]])

// -----

Expand Down