Make CustomCallThunk own the associated HloComputation #97429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CustomCallThunk used to hold a raw pointer to a HloComputation that would be passed to the custom call target. It relied on the HloComputation being alive as long as the thunk existed which is a thing that we can't necessarily guarantee and it just happended to work. There was an open TODO to replace the pointer by a copy of the HloComputation which is done in this CL. This change is also a prerequisite for proto serialization of CustomCallThunk. PiperOrigin-RevId: 786251950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make CustomCallThunk own the associated HloComputation
CustomCallThunk used to hold a raw pointer to a HloComputation
that would be passed to the custom call target. It relied on the
HloComputation being alive as long as the thunk existed which is a thing
that we can't necessarily guarantee and it just happended to work.
There was an open TODO to replace the pointer by a copy of the HloComputation which is done in this CL.
This change is also a prerequisite for proto serialization of CustomCallThunk.