Give better error in run_hlo_module if HLO has collectives. #97208
+54
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, it would segfault, as run_hlo_module (and xla::HloRunner in general) doesn't set a DeviceAssignment and the CollectiveThunk would try to deference a null DeviceAssignment pointer. PiperOrigin-RevId: 785279494
0d32bbf to
1591203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give better error in run_hlo_module if HLO has collectives.
Before, it would segfault, as run_hlo_module (and xla::HloRunner in general) doesn't set a DeviceAssignment and the CollectiveThunk would try to deference a null DeviceAssignment pointer. I keep accidentally using run_hlo_module instead of multihost_hlo_runner and got sick of the segfaults.