这是indexloc提供的服务,不要输入任何密码
Skip to content

Bug Fix: Make the runs data table only show a scrollbar when needed #6656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

rileyajones
Copy link
Contributor

Motivation for features / changes

The runs table previously always showed the scroll bar. Now it only shows when there are enough runs.

Screenshots of UI changes (or N/A)

Before (no scroll):
image

Before (with scroll):
image

After (no scroll):
image

After (with scroll):
image

@rileyajones rileyajones marked this pull request as ready for review October 20, 2023 21:45
@rileyajones rileyajones force-pushed the runs-data-table-scroll branch from b7e1fc7 to 22c7b16 Compare October 24, 2023 23:01
@rileyajones rileyajones merged commit ceb473c into tensorflow:master Oct 25, 2023
bmd3k pushed a commit to bmd3k/tensorboard that referenced this pull request Nov 2, 2023
@bmd3k bmd3k mentioned this pull request Nov 2, 2023
bmd3k pushed a commit that referenced this pull request Nov 2, 2023
…6656)

## Motivation for features / changes
The runs table previously always showed the scroll bar. Now it only
shows when there are enough runs.

## Screenshots of UI changes (or N/A)
Before (no scroll):

![image](https://github.com/tensorflow/tensorboard/assets/78179109/ab6f197e-1494-4c3a-b11d-88e181860e8b)

Before (with scroll):

![image](https://github.com/tensorflow/tensorboard/assets/78179109/ff5908ee-5a75-4153-9a93-d541c5980d51)

After (no scroll):

![image](https://github.com/tensorflow/tensorboard/assets/78179109/e287cf02-8cc2-4386-baee-505a5b406266)

After (with scroll):

![image](https://github.com/tensorflow/tensorboard/assets/78179109/78c45e94-38aa-4997-971d-d7148d548bda)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants