[CMake] Add dependencies missing for building shared libraries. #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds CMake dependencies that are required for building the project with -DBUILD_SHARED_LIBS and currently missing. I am doing this here https://github.com/iree-org/iree-llvm-sandbox/blob/b1c16a5/configure.py#L229 through IREE (https://github.com/iree-org/iree). The reason why I believe the problems did not show up is because everybody including CI seem to use static linking and not all required symbols are required for linking static libraries -- they only need to be present when linking the final executable, where they presumable get linked in "by chance".
|
Abandoning in favor of tensorflow/tensorflow#59421, which I guess is where PRs should go... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CMake dependencies that are required for building the project with -DBUILD_SHARED_LIBS and currently missing. I am doing this here https://github.com/iree-org/iree-llvm-sandbox/blob/b1c16a5/configure.py#L229 through IREE (https://github.com/iree-org/iree).
The reason why I believe the problems did not show up is because everybody including CI seem to use static linking and not all required symbols are required for linking static libraries -- they only need to be present when linking the final executable, where they presumable get linked in "by chance".
I have only tested building this project as a dependency of IREE, not as a stand-alone project.