Add canonicalization for mhlo.dynamic_conv to mhlo.convolution #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The case where the padding value is constant for mhlo.convolution can be lowered to mhlo.convolution directly by copying the pad values in.
sdasgup3
approved these changes
Dec 8, 2022
|
Hi Rob! Thank you for your contribution and LGTM. We're not yet at a stage where contributions to MHLO can be conveniently done through GitHub (e.g. this repository is read-only), so may I ask you to send this patch as a CL through Critique or as a PR through tensorflow/tensorflow? |
burmako
approved these changes
Dec 10, 2022
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
-- b20a310 by Rob Suderman <suderman@google.com>: Add canonicalization for mhlo.dynamic_conv to mhlo.convolution The case where the padding value is constant for mhlo.convolution can be lowered to mhlo.convolution directly by copying the pad values in. COPYBARA_INTEGRATE_REVIEW=#54 from rsuderman:DyanmicConvCanonicalization b20a310 PiperOrigin-RevId: 495179170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case where the padding value is constant for mhlo.convolution can be lowered to mhlo.convolution directly by copying the pad values in.