Added dynamic support for general_dot canonicalization #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General dot needs to be converted to a typical form. The existing version only handled static cases. The improved version converts to a dynamic compatible form while restricting to static operations as often as possible.
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 25, 2022
-- 1e0aab3 by Rob Suderman <rob.suderman@gmail.com>: Added dynamic support for general_dot canonicalization General dot needs to be converted to a typical form. The existing version only handled static cases. The improved version converts to a dynamic compatible form while restricting to static operations as often as possible. COPYBARA_INTEGRATE_REVIEW=#26 from rsuderman:tfGeneralDot 1e0aab3 PiperOrigin-RevId: 424154878
|
This has landed internally and will get propagated to tensorflow/tensorflow (and then back to this repo) soon. |
|
The notification from "copybara-service" above is from the actual commit in this repo :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General dot needs to be converted to a typical form. The existing version only
handled static cases. The improved version converts to a dynamic compatible
form while restricting to static operations as often as possible.