Group servers in upstream #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| groupedByServer[index].Responses.FourXx += upstream.Responses.FourXx | ||
| groupedByServer[index].Responses.FiveXx += upstream.Responses.FiveXx | ||
| groupedByServer[index].RequestMsec = (groupedByServer[index].RequestMsec + upstream.RequestMsec) / 2 | ||
| groupedByServer[index].ResponseMsec = (groupedByServer[index].ResponseMsec + upstream.ResponseMsec) / 2 |
There was a problem hiding this comment.
upstream.ResponseMsec seems to be computed as an average, but computing an average on top of averages cannot technically be considered an average. For example, I think for a single server in upstream with ResponseMsec=42ms the aggregated ResponseMsec would be 21ms ((0 + 42) / 2 = 21), which is different from the expected 42ms.
I'd convert the averages back to the sums of times (assuming that RequestCounter is the denominator of the averages), and then compute the aggregated average using the sums, something like this:
if (groupedByServer[index].RequestCounter + upstream.RequestCounter) > 0 {
groupedByServer[index].RequestMsec = (groupedByServer[index].RequestMsec * groupedByServer[index].RequestCounter + upstream.RequestMsec * upstream.RequestCounter) / (groupedByServer[index].RequestCounter + upstream.RequestCounter)
groupedByServer[index].ResponseMsec = (groupedByServer[index].ResponseMsec * groupedByServer[index].RequestCounter + upstream.ResponseMsec * upstream.RequestCounter) / (groupedByServer[index].RequestCounter + upstream.RequestCounter)
}
groupedByServer[index].RequestCounter += upstream.RequestCounter // note that this increment has to happen *after* the averages
Despite this little issue -- thank you for the great patch!
(Note, I'm not a maintainer of this project, I just faced the same issue and have reused your helpful solution).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix issue: If you put the same server multiple times to upstream you will get an error "...was collected before with the same name and label" But I have to use this for retries to the same server