Clarify Durable, Add Consumer Name Prefix #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilakraj94
reviewed
Aug 19, 2025
tilakraj94
reviewed
Aug 19, 2025
src/main/java/io/synadia/flink/source/JetStreamSubjectConfiguration.java
Show resolved
Hide resolved
Collaborator
|
@scottf, it looks like the certs changes also got pushed. You may want to force push and remove those from the commit. Only one question, rest LGTM. |
Collaborator
|
Pls make changes to this place as well https://github.com/synadia-io/flink-connector-nats?tab=readme-ov-file#durable-consumers |
Collaborator
Author
I needed the certs for the unit tests since I run against the head of main server. |
Collaborator
|
LGTM @scottf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.