add news feature #48
add news feature #48
Conversation
|
wit ai needs training to get intent of query in test_news |
modules/src/news.py
Outdated
|
|
||
|
|
||
|
|
||
|
|
|
Hey @Badmon, nice work! |
|
I just did, seems to me we aren't breaking any rules ? |
|
what further progress is there before branch gets merged? |
|
See https://developer.nytimes.com/branding, need to add "Data provided by The New York Times" at the end. |
|
I've trained wit.ai, the tests are now passing! 🎉 |
|
deleted my branch by mistaken -- is it possible for me to create another news-feature branch ? |
|
oh my bad -- git reflog 👍 |
|
funny thing is cant seem to find a template that allows me to display "data provided by new york times" |
|
Keep the snippet in the subtitle, and put the attribution in place of 'View on Web'. |
|
alright, on it! |
|
still merge conflicts, kindly sync your fork with upstream |
|
i have, still having conflicts |
|
The conflict is in line number 6 in config.py |
|
done ? |
| template.set_post_text('\nCommunity Rating: ' + str(data[0]['community_rating']) + '\nStatus: ' + data[0]['status']) | ||
| #only want to see 2 decimal places | ||
| rating = {0:.2f}.format(data[0]['community_rating']) | ||
| template.set_post_text('\nCommunity Rating: ' + str(rating) + '\nStatus: ' + data[0]['status']) |
|
i just realized how terrible i am at git, i will do that soon |
|
No problem, take your time 😄 Let me know if you need any help! |
|
want commands do i run to resolve the conflicts ? i tried git fetch upstream && git merge upstream/master |
Conflicts: data/jokes.json
|
Nice work! Conflicts have been resolved. |
| @@ -1,4 +1,5 @@ | |||
| { | |||
|
|
|||
|
Merged in #147 |
news functionality implemented using new york times articles api