Feature to check whether a website is running or not #197
Conversation
swapagarwal
left a comment
There was a problem hiding this comment.
The structure looks good overall. 😄
modules/src/__init__.py
Outdated
| 'url', | ||
| 'video', | ||
| 'weather', | ||
| 'webcheck', |
There was a problem hiding this comment.
Can we rename it to ping module? It's more intuitive.
modules/src/webcheck.py
Outdated
| strip_list = ['http://','https://','/'] | ||
| for item in strip_list: | ||
| url = url.strip(item) | ||
| page = requests.get('https://isitup.org/'+str(url)) |
There was a problem hiding this comment.
Pro Tip: See what happens if you append .json to the end of the URL..
|
Thanks for the feedback! Applied the proposed changes :) |
swapagarwal
left a comment
There was a problem hiding this comment.
The training for this module is complete. Address the following comments, and this module is good to go! 😄
modules/src/ping.py
Outdated
| @@ -0,0 +1,35 @@ | |||
| import requests | |||
| import json | |||
modules/src/ping.py
Outdated
| for item in strip_list: | ||
| url = url.strip(item) | ||
| page = requests.get('https://isitup.org/'+url+'.json') | ||
| page = json.loads(page.text) |
There was a problem hiding this comment.
If you see the other modules, the general structure is:
r = requests.get(...)
data = r.json()
modules/src/ping.py
Outdated
| output['error_msg'] = TextTemplate(error_message).get_message() | ||
| output['success'] = False | ||
| return output | ||
|
|
modules/src/ping.py
Outdated
| output['success'] = True | ||
| except: | ||
| error_message = 'There seems to be some problem' | ||
| error_message = '\nPlease ask me something else, like:' |
There was a problem hiding this comment.
It should be "+=". Check the below lines too.
modules/src/ping.py
Outdated
| page = json.loads(page.text) | ||
| status = page['status_code'] | ||
| if status == 1: | ||
| txt = orig_url + ' is up!' |
There was a problem hiding this comment.
Don't use original url here, as that might be misleading. Use the one that we passed in the api call.
modules/src/ping.py
Outdated
| txt = orig_url + ' is up!' | ||
| elif status == 2: | ||
| txt = orig_url + ' seems to be down!' | ||
| else : |
There was a problem hiding this comment.
Do we know the status code here? If yes, then we should use that here instead. Any unexpected status codes should result in an error.
modules/src/ping.py
Outdated
| strip_list = ['http://','https://','/'] | ||
| for item in strip_list: | ||
| url = url.strip(item) | ||
| page = requests.get('https://isitup.org/'+url+'.json') |
modules/src/ping.py
Outdated
| try: | ||
| url = entities['url'][0]['value'] | ||
| orig_url = url | ||
| strip_list = ['http://','https://','/'] |
There was a problem hiding this comment.
Add a space after comma. Can you explain why the third entry in the list is required?
There was a problem hiding this comment.
Coz queries like google.com/ will cause wrong domain name error.
|
Thanks @swapagarwal :) |
|
Congratulations! 🎉 |
Checks whether a web domain is up or not using isitup.org. Needs to learn 'Is xyz.com up', 'xyz.com status'.