Add another API for jokes #12
Conversation
|
I agree that this is a good idea - maybe using a small web scraping script to pull from parts of the web with an abundance of jokes. Ex. https://www.reddit.com/r/dadjokes Then grab the title / body of the posts and push it to the other projects |
|
@havanagrawal Great finds! |
|
I feel we should keep both, as they both are different genres (one-liners vs Chuck Norris).. Eventually, we can take genre requests too for the joke api, and these will be handy then.. But by all means, if you want me to replace it, I'll replace it 😄 |
|
I also want to keep both but if you query the chuck norris api multiple times, you'll find some offensive jokes that I want to avoid. We have users requesting for different genre jokes so that's our next priority. But for now, our main aim is to filter out jokes (which the tambal api already has). |
|
|
# This is the 1st commit message: Added more tests to test_anime # This is the commit message swapagarwal#2: Changed Hummingbird API to Kitsu # This is the commit message swapagarwal#3: Added bad query test to test_anime # This is the commit message swapagarwal#4: Based slice length on len # This is the commit message swapagarwal#5: Removed repeated searches. # This is the commit message swapagarwal#6: Broke tests into different functions. # This is the commit message swapagarwal#7: Removed whitespace. # This is the commit message swapagarwal#8: Added tests based on API response and rating format. # This is the commit message swapagarwal#9: Reorganized some calls. # This is the commit message swapagarwal#10: Refactored API requests, added tests for rank and episode count # This is the commit message swapagarwal#11: Added another test case. # This is the commit message swapagarwal#12: Added tests for kitsu and youtube links # This is the commit message swapagarwal#13: Stickler corrections. # This is the commit message swapagarwal#14: More Stickler corrections. # This is the commit message swapagarwal#15: More Stickler corrections. # This is the commit message swapagarwal#16: Stickler corrections. # This is the commit message swapagarwal#17: Moved declarations closer to point used. # This is the commit message swapagarwal#18: Style corrections. # This is the commit message swapagarwal#19: Style correction
I wonder if, instead of developing our own list of jokes, why not look for repos on GitHub that might have aggregated such a list?
Perhaps contributing to, and then somehow sourcing from such repos would prove to be more productive.. Just a thought..
API Credit: https://github.com/KiaFathi/tambalAPI
Some other possible sources:
https://github.com/CallumBarclay/Jokes-API
https://github.com/ChrisMcKenzie/dadjokes