Add source address used in test in failure report #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
summerwind
approved these changes
Jun 9, 2020
Owner
summerwind
left a comment
There was a problem hiding this comment.
Thank you for the PR! I think that this is very useful for debugging!
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When h2spec reports a failure, knowing the source address and port used by the failed test can be very useful when tracing the problem in the server's log, so it would be great to have this extra feature.
Here's a quick (and dirty?) patch that does exactly this.
Thanks for considering it!