allow update method to only update email address #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usecase : user wants to change email only. this change prevents a case where sending empty string to the server will cause the request to fail
Collaborator
|
Isn't an empty string ignored? Do supabase accepts |
Author
|
True, to some extent it depends on the authentication password policies set in Supabase.It would probably be cleaner to add an additionally method for specifically updating the email address.If you agree I can make the changesSent from my iPhoneOn 24 Jan 2023, at 20:30, Nicolò Santilio ***@***.***> wrote:
Isn't an empty string ignored? Do supabase accepts "" as a new password value?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Collaborator
|
Agreed. Let's have different methods |
Collaborator
|
Thanks again! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usecase : user wants to change email only.
this change prevents a case where sending empty string to the server will cause the request to fail
What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.