Guard against malformed json input for custom functions #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
The changes in this pull request look good. It adds error handling for parsing JSON in the |
ethdegen
pushed a commit
to ethdegen/superagent
that referenced
this pull request
Dec 13, 2023
…i#551) * Guard agains malformed json input for custom functions * Remove console.log
ethdegen
pushed a commit
to ethdegen/superagent
that referenced
this pull request
Dec 13, 2023
…i#551) * Guard agains malformed json input for custom functions * Remove console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue with the user being able to save a malformed JSON when setting up a custom function in UI.
Checklist
make format.