这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@homanp
Copy link
Collaborator

@homanp homanp commented Sep 18, 2023

Summary

This PR reverts the Fern CI to only trigger on tagged releases.

Checklist

  • My code follows the code style of this project and passes make format.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change has adequate unit test coverage.

@homanp homanp added the enhancement New feature or request label Sep 18, 2023
@homanp homanp self-assigned this Sep 18, 2023
@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
superagent ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 6:23am
superagent-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 6:23am
superagent-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 6:23am

@homanp
Copy link
Collaborator Author

homanp commented Sep 18, 2023

@homanp, thank you for the pull request! Here are my suggestions for improvement:

  1. In the ci.yml file, it would be better to use the github.ref instead of github.ref_name in the run command. This will ensure that the correct version is used. Here's the updated code:
run: fern generate --group publish --log-level debug --version ${{ github.ref }} --api prod

That's it! Let me know if you have any questions. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants