fix: use base64 encoding to avoid shell escaping issues with JSON content #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mg-dev25 is attempting to deploy a commit to the Superagent Team on Vercel. A member of the Team first needs to authorize it. |
df51ffb to
b7da616
Compare
Collaborator
|
@mg-dev25 ping when you want me to review. Please split into 2 separate prs if possible |
b7da616 to
b98e6f5
Compare
…tent Encode settings JSON as base64 before embedding in bash script to prevent shell escaping issues when JSON contains special characters
…tent Encode settings JSON as base64 before embedding in bash script to prevent shell escaping issues when JSON contains special characters like quotes. Also update Claude settings path to use os.homedir() for better cross-platform compatibility instead of hardcoded /root/.claude.json path. Fixes superagent-ai#224: Resolves 'bash: -c: line 2: unexpected EOF while looking for matching quote' error on ARM Ubuntu servers when JSON settings contain special characters that break shell parsing.
b98e6f5 to
2ba50d5
Compare
Collaborator
|
@mg-dev25 is this ready? |
Contributor
Author
|
@homanp This PR is ready and test, but I will push other issue I found not relate to this one that make Claude code not operate completely or crash. |
homanp
approved these changes
Oct 1, 2025
Collaborator
homanp
left a comment
There was a problem hiding this comment.
Thank you for this contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed shell escaping issues when JSON contains special characters by encoding settings JSON as base64 before embedding in bash script.
Related Issue
Fixes #224
Changes
claude-auth-helper.jsto encode JSON settings as base64 before passing to shellChecklist