Collect phone and email from Apple Pay when required #5199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tests for requiredShippingContactFields configuration - Add tests for BillingDetails extraction from PKPayment - Verify phone/email are collected through shipping contact - Test fallback logic when billing contact lacks phone/email 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1662b06 to
1002657
Compare
Add entry documenting that Apple Pay now properly collects phone number and email address when marked as required in PaymentSheetConfig. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ | |||
| * [Added] Added `Appearance.EmbeddedPaymentElement.Row.titleFont` to customize the font of EmbeddedPaymentElement payment method row titles. | |||
| * [Changed] Renamed `PaymentSheet.Appearance.EmbeddedPaymentElement.Row.Style.flatWithChevron` to `PaymentSheet.Appearance.EmbeddedPaymentElement.Row.Style.flatWithDisclosure` and added an experimental `disclosureImage` property to customize the chevron icon displayed in EmbeddedPaymentElement payment method rows when the row style is flatWithDisclosure. | |||
| * [Fixed] `EmbeddedPaymentElementDelegate` `didUpdateHeight` now accommodates cases where the embedded view can't change height until after `didUpdateHeight` is called, like inside a UITableViewCell. | |||
| * [Fixed] Apple Pay now properly collects phone number and email address when marked as required in PaymentSheetConfig billing details collection configuration. | |||
There was a problem hiding this comment.
Suggested change
| * [Fixed] Apple Pay now properly collects phone number and email address when marked as required in PaymentSheetConfig billing details collection configuration. | |
| * [Fixed] Apple Pay now properly collects phone number and email address when marked as required in `PaymentSheet.BillingDetailsCollectionConfiguration`. |
There was a problem hiding this comment.
Noticed that too, just fixed it!
tillh-stripe
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
requiredShippingContactFieldsinstead ofrequiredBillingContactFieldsBillingDetails+ApplePay.swiftthat extracts phone/email fromshippingContactwhen not available inbillingContactChanges Made
Test plan
🤖 Generated with Claude Code