这是indexloc提供的服务，不要输入任何密码
Skip to content

Rename FlatWithChevron to FlatWithDisclosure #11175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 21, 2025
Merged

Rename FlatWithChevron to FlatWithDisclosure #11175

merged 3 commits into from
Jul 21, 2025

Conversation

tjclawson-stripe
Copy link
Collaborator

@tjclawson-stripe tjclawson-stripe commented Jul 21, 2025 •
edited
Loading

Summary

Rename FlatWithChevron to FlatWithDisclosure
No behavior change

Motivation

API Review

Testing

  • Added tests
  • Modified tests
  • Manually verified

@tjclawson-stripe tjclawson-stripe marked this pull request as ready for review July 21, 2025 19:54
@tjclawson-stripe tjclawson-stripe requested review from a team as code owners July 21, 2025 19:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025 •
edited
Loading

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │ +2 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.9 KiB │ 302.9 KiB │  0 B │   457 KiB │   457 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.7 KiB │   7.7 KiB │  0 B │   7.4 KiB │   7.4 KiB │  0 B 
    other │  95.7 KiB │  95.8 KiB │ +7 B │ 183.5 KiB │ 183.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.8 MiB │   9.8 MiB │ +9 B │  21.8 MiB │  21.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20688 │ 20688 │ 0 (+0 -0) 
   types │  6507 │  6507 │ 0 (+0 -0) 
 classes │  5270 │  5270 │ 0 (+0 -0) 
 methods │ 31521 │ 31521 │ 0 (+0 -0) 
  fields │ 18243 │ 18243 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3646 │ 3646 │  0
APK 
   compressed    │  uncompressed   │                        
──────────┬──────┼──────────┬──────┤                        
 size     │ diff │ size     │ diff │ path                   
──────────┼──────┼──────────┼──────┼────────────────────────
 29.2 KiB │ +5 B │ 64.6 KiB │  0 B │ ∆ META-INF/CERT.SF     
  2.1 MiB │ +2 B │  4.3 MiB │  0 B │ ∆ classes.dex          
 25.9 KiB │ +2 B │ 64.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼──────┼──────────┼──────┼────────────────────────
  2.1 MiB │ +9 B │  4.5 MiB │  0 B │ (total)

@tjclawson-stripe tjclawson-stripe marked this pull request as draft July 21, 2025 19:57
jaynewstrom-stripe
jaynewstrom-stripe reviewed Jul 21, 2025
View reviewed changes
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have analytics on how often/who uses this?

@tjclawson-stripe
Copy link
Collaborator Author

Do we have analytics on how often/who uses this?

@jaynewstrom-stripe just our test apps and one user who is expecting the change

@jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe just our test apps and one user who is expecting the change

Thanks!

@tjclawson-stripe tjclawson-stripe marked this pull request as ready for review July 21, 2025 20:24
@tjclawson-stripe tjclawson-stripe enabled auto-merge (squash) July 21, 2025 20:24
@tjclawson-stripe tjclawson-stripe merged commit 8c6a885 into master Jul 21, 2025
13 checks passed
@tjclawson-stripe tjclawson-stripe deleted the tyler/rename-chevron branch July 21, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaynewstrom-stripe jaynewstrom-stripe jaynewstrom-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjclawson-stripe @jaynewstrom-stripe