这是indexloc提供的服务，不要输入任何密码
Skip to content

[link] Provide account info for internal usage #11207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 25, 2025
Merged

[link] Provide account info for internal usage #11207

merged 6 commits into from
Jul 25, 2025
+100 −9

Conversation

lng-stripe
Copy link
Contributor

Summary

Add internalLinkAccount to LinkController.State.

Motivation

👻

Testing

  • Added tests
  • Modified tests
  • Manually verified

@lng-stripe lng-stripe requested review from a team as code owners July 24, 2025 21:59
@lng-stripe lng-stripe removed the request for review from tjclawson-stripe July 24, 2025 21:59
carlosmuvi-stripe
carlosmuvi-stripe previously approved these changes Jul 24, 2025
View reviewed changes
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this so fast!

paymentsheet/src/main/java/com/stripe/android/link/LinkController.kt
Comment on lines +281 to +283
@get:RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
@field:RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
val internalLinkAccount: LinkAccount? = null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - do we want to add this to the javadocs above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. It's not something we'll want to make public in the future.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025 •
edited
Loading

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │   2.1 MiB │   2.1 MiB │   +9 B │   4.3 MiB │   4.3 MiB │    0 B 
     arsc │     1 MiB │     1 MiB │ +824 B │     1 MiB │     1 MiB │ +824 B 
 manifest │   2.3 KiB │   2.3 KiB │    0 B │     8 KiB │     8 KiB │    0 B 
      res │ 302.9 KiB │ 302.9 KiB │    0 B │   457 KiB │   457 KiB │    0 B 
   native │   6.2 MiB │   6.2 MiB │    0 B │  15.8 MiB │  15.8 MiB │    0 B 
    asset │   7.7 KiB │   7.7 KiB │   +1 B │   7.4 KiB │   7.4 KiB │   +1 B 
    other │  95.7 KiB │  95.7 KiB │   +3 B │ 183.5 KiB │ 183.5 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │   9.8 MiB │   9.8 MiB │ +837 B │  21.8 MiB │  21.8 MiB │ +825 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20688 │ 20688 │ 0 (+0 -0) 
   types │  6507 │  6507 │ 0 (+0 -0) 
 classes │  5270 │  5270 │ 0 (+0 -0) 
 methods │ 31521 │ 31521 │ 0 (+0 -0) 
  fields │ 18243 │ 18243 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3646 │ 3646 │  0
APK 
    compressed     │   uncompressed    │                               
──────────┬────────┼──────────┬────────┤                               
 size     │ diff   │ size     │ diff   │ path                          
──────────┼────────┼──────────┼────────┼───────────────────────────────
    1 MiB │ +824 B │    1 MiB │ +824 B │ ∆ resources.arsc              
  2.1 MiB │   +9 B │  4.3 MiB │    0 B │ ∆ classes.dex                 
  6.8 KiB │   +1 B │  6.7 KiB │   +1 B │ ∆ assets/dexopt/baseline.prof 
 29.2 KiB │   +1 B │ 64.6 KiB │    0 B │ ∆ META-INF/CERT.SF            
  1.2 KiB │   +1 B │  1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA           
 25.9 KiB │   +1 B │ 64.5 KiB │    0 B │ ∆ META-INF/MANIFEST.MF        
──────────┼────────┼──────────┼────────┼───────────────────────────────
  3.2 MiB │ +837 B │  5.5 MiB │ +825 B │ (total)

@lng-stripe lng-stripe force-pushed the lng/lc-account-info branch from 4fc71e9 to 2f91f51 Compare July 24, 2025 23:59
@lng-stripe lng-stripe merged commit b070950 into master Jul 25, 2025
13 checks passed
@lng-stripe lng-stripe deleted the lng/lc-account-info branch July 25, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosmuvi-stripe carlosmuvi-stripe carlosmuvi-stripe approved these changes

Assignees

@carlosmuvi-stripe carlosmuvi-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lng-stripe @carlosmuvi-stripe