这是indexloc提供的服务，不要输入任何密码
Skip to content

Add FormInsets API #10919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 9, 2025
Merged

Add FormInsets API #10919

merged 9 commits into from
Jun 9, 2025

Conversation

tjclawson-stripe
Copy link
Collaborator

@tjclawson-stripe tjclawson-stripe commented Jun 4, 2025 •
edited
Loading

Summary

Add FormInsets API to Appearance
Add Form Insets to AppearanceBottomSheetDialog

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-3607

Testing

  • Added tests
  • Modified tests
  • Manually verified
Screen.Recording.2025-06-04.at.5.53.26.PM.mov

Changelog

[ADDED][10919](https://github.com/stripe/stripe-android/pull/10919) Add `formInsetValues` to `PaymentSheet.Appearance`.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025 •
edited
Loading

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │   0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.9 KiB │ 302.9 KiB │   0 B │   457 KiB │   457 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.7 KiB │   7.7 KiB │   0 B │   7.4 KiB │   7.4 KiB │  0 B 
    other │  95.8 KiB │  95.7 KiB │ -12 B │ 183.5 KiB │ 183.5 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │   9.8 MiB │   9.8 MiB │ -12 B │  21.8 MiB │  21.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20663 │ 20663 │ 0 (+0 -0) 
   types │  6492 │  6492 │ 0 (+0 -0) 
 classes │  5258 │  5258 │ 0 (+0 -0) 
 methods │ 31487 │ 31487 │ 0 (+0 -0) 
  fields │ 18210 │ 18210 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3646 │ 3646 │  0
APK 
    compressed    │   uncompressed   │                        
──────────┬───────┼───────────┬──────┤                        
 size     │ diff  │ size      │ diff │ path                   
──────────┼───────┼───────────┼──────┼────────────────────────
 29.2 KiB │  -5 B │  64.6 KiB │  0 B │ ∆ META-INF/CERT.SF     
 25.9 KiB │  -5 B │  64.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
  1.2 KiB │  -2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
──────────┼───────┼───────────┼──────┼────────────────────────
 56.2 KiB │ -12 B │ 130.4 KiB │  0 B │ (total)

@tjclawson-stripe tjclawson-stripe marked this pull request as ready for review June 6, 2025 20:22
@tjclawson-stripe tjclawson-stripe requested review from a team as code owners June 6, 2025 20:22
tjclawson-stripe
tjclawson-stripe commented Jun 6, 2025
View reviewed changes
...n/java/com/stripe/android/paymentsheet/example/playground/PaymentSheetPlaygroundViewModel.kt
@@ -639,6 +641,24 @@ internal class PaymentSheetPlaygroundViewModel(
}
}

fun updateFormInsetsAppearance(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't ideal but we can't read from the insets class in AppearanceBottomSheetDialogFragment as it's internal in Appearance. I will look into persisting the entire Appearance config as a single setting.

@tjclawson-stripe tjclawson-stripe merged commit edab478 into master Jun 9, 2025
13 checks passed
@tjclawson-stripe tjclawson-stripe deleted the tyler/form-insets-api branch June 9, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samer-stripe samer-stripe samer-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjclawson-stripe @samer-stripe