Remove legacy tenancy config #802

fomalhautb · 2025-07-24T21:08:38Z

Important

Refactor codebase to remove legacy tenancy configuration, updating domain, OAuth, email, and permission handling to use new config structure.

Behavior:
- Refactor to use tenancy.config instead of tenancy.completeConfig in multiple files for domains, OAuth providers, and email configurations.
- Update validateRedirectUrl() to use tenancy.config.domains.trustedDomains.
- Modify getProvider() to handle provider.isShared and provider.type.
Domains:
- Update domain handling in crud.tsx files for custom and neon integrations to use trustedDomains.
OAuth Providers:
- Refactor OAuth provider logic in crud.tsx files to use new config structure.
- Adjust getProviderConfig() and related functions to accommodate new config.
Emails:
- Change email template and theme handling to use tenancy.config.emails.
- Update email sending logic to reflect new email configuration structure.
Permissions:
- Refactor permission handling functions to use tenancy.config.rbac.permissions.
Misc:
- Update tests in send-sign-in-code.test.ts to reflect changes in OTP sign-in logic.
- Minor refactoring in prisma-client.tsx to align with new tenancy config.

^{This description was created by}^{for bc069b0. You can customize this summary. It will automatically update as commits are pushed.}

vercel · 2025-07-24T21:08:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
stack-backend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 24, 2025 11:11pm
stack-dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 24, 2025 11:11pm
stack-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 24, 2025 11:11pm
stack-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 24, 2025 11:11pm

apps/backend/prisma/seed.ts

recurseml · 2025-07-24T21:10:06Z

😱 Found 1 issue. Time to roll up your sleeves! 😱

🗒️ View all ignored comments in this repo

The constraint 'TokenStoreType extends string' is too restrictive. It should likely be 'TokenStoreType extends string | object' to match the condition check in line 113 where TokenStoreType is checked against {}
Return type mismatch - the interface declares useUsers() returning ServerUser[] but the Team interface that this extends declares useUsers() returning TeamUser[]
There is a syntax error in the super constructor call due to the ellipsis operator used incorrectly. Objects aren't being merged correctly. This syntax usage can lead to runtime errors when trying to pass the merged object to 'super()'. Verify that the intended alterations to the object occur before or outside of the super() call if needed.
Throwing an error when no active span is found is too aggressive. The log function should gracefully fallback to console.log or another logging mechanism when there's no active span, since not all execution contexts will have an active span. This makes the code less resilient and could break functionality in non-traced environments.

📚 Relevant Docs

Function sets backendContext with a new configuration but doesn't pass 'defaultProjectKeys'. Since defaultProjectKeys is required in the type definition and cannot be updated (throws error if tried to set), this will cause a type error.
The schema is using array syntax for pick() which is incorrect for Yup schemas. The pick() method in Yup expects individual arguments, not an array. Should be changed to: emailConfigSchema.pick('type', 'host', 'port', 'username', 'sender_name', 'sender_email')

📚 Relevant Docs

Creating a refresh token with current timestamp as expiration means it expires immediately. Should set a future date for token expiration.
The 'tools' object is initialized as an empty object, even though 'tools' is presumably expected to contain tool definitions. This could cause the server capabilities to lack necessary tool configurations, thus potentially impacting functionalities that depend on certain tool setups.

📚 Relevant Docs

'STACK_SECRET_SERVER_KEY' is potentially being included in every request header without checking its existence again here. Although it's checked during initialization, this could lead to security issues as it's exposed in all communications where the header is logged or captured.

📚 Relevant Docs

When adding 'use client' directive at the beginning, it doesn't check if file.text already contains the 'use client' directive. This could lead to duplicate 'use client' directives if the file already has one.

📚 Relevant Docs

⚠️ Only 5 files were analyzed due to processing limits.

^{Need help? Join our Discord for support!
https://discord.gg/qEjHQk64Z9}

apps/backend/src/lib/ai-chat/email-template-adapter.ts

apps/backend/src/lib/ai-chat/email-theme-adapter.ts

greptile-apps

Greptile Summary

This PR represents a comprehensive refactoring to remove legacy tenancy configuration patterns throughout the Stack Auth codebase. The changes migrate from a dual configuration system (with both config and completeConfig properties) to a unified, hierarchical configuration structure.

The key architectural changes include:

Configuration Structure Modernization: The PR eliminates the legacy completeConfig property from tenancy objects and consolidates all configuration access through the config property, which now directly contains the rendered organization configuration.
Hierarchical Configuration Schema: The flat configuration structure has been replaced with a nested organization where related settings are grouped logically:
- Authentication settings moved from credential_enabled, sign_up_enabled, passkey_enabled to auth.password.allowSignIn, auth.allowSignUp, auth.passkey.allowSignIn
- Domain configuration restructured from flat arrays to domains.trustedDomains objects with baseUrl and handlerPath properties
- OAuth providers reorganized from arrays to keyed objects under auth.oauth.providers
- Email configuration moved from email_config.type to emails.server.isShared
API Simplification: Functions like validateRedirectUrl have been updated to accept entire tenancy objects instead of individual configuration parameters, centralizing configuration access logic and reducing parameter coupling.
Transformation Layer: The renderedOrganizationConfigToProjectCrud function is now used to transform the new organization config format into the expected project CRUD interface format for API responses, maintaining backward compatibility while supporting the new internal structure.
New Environment Config CRUD: A new environment configuration management system has been introduced with proper CRUD operations, supporting the transition from legacy tenancy-based configuration to environment-level configuration management.

The changes affect authentication flows (password, OTP, passkey, OAuth), email systems, domain validation, API key management, team creation, user management, and various internal configuration endpoints. All modifications maintain functional equivalence while adopting the cleaner, more maintainable configuration architecture.

Confidence score: 3/5

• This PR has significant architectural changes that could introduce subtle bugs if configuration transformations are incorrect
• The migration from legacy to new config structure requires careful validation to ensure all property mappings are accurate
• Files like apps/backend/src/app/api/latest/auth/otp/send-sign-in-code/route.tsx have inconsistent error messaging and several files use generic yupMixed() validation that lacks type safety

_{46 files reviewed, 6 comments}

_{Edit Code Review Bot Settings | Greptile}

apps/backend/prisma/seed.ts

apps/backend/src/app/api/latest/auth/otp/send-sign-in-code/route.tsx

apps/backend/src/app/api/latest/internal/environment-config/current/crud.tsx

apps/backend/src/oauth/index.tsx

apps/backend/src/app/api/latest/integrations/neon/oauth-providers/crud.tsx

apps/backend/src/lib/redirect-urls.tsx

…ers/crud.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

…te.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

fomalhautb added 4 commits July 24, 2025 13:00

remove old config

a9ceab2

fix validateRedirectUrl

6390832

fix tenancy config

1f02532

fix

588019d

github-actions bot assigned fomalhautb Jul 24, 2025

recurseml bot reviewed Jul 24, 2025

View reviewed changes

apps/backend/prisma/seed.ts Outdated Show resolved Hide resolved

fomalhautb added 6 commits July 24, 2025 14:10

better error handling

86466a9

fix

3d38936

fix

506ff7d

fix

5d7bcc0

fix

3626c5c

fix

76f593a

fomalhautb marked this pull request as ready for review July 24, 2025 22:06

fomalhautb assigned N2D4 and unassigned fomalhautb Jul 24, 2025

fomalhautb requested a review from N2D4 July 24, 2025 22:06

remove environment-config

0b00d8c

ellipsis-dev bot reviewed Jul 24, 2025

View reviewed changes

apps/backend/src/lib/ai-chat/email-template-adapter.ts Show resolved Hide resolved

apps/backend/src/lib/ai-chat/email-theme-adapter.ts Show resolved Hide resolved

greptile-apps bot reviewed Jul 24, 2025

View reviewed changes

fomalhautb and others added 6 commits July 25, 2025 00:29

Update apps/backend/src/app/api/latest/integrations/neon/oauth-provid…

62b7775

…ers/crud.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update apps/backend/src/app/api/latest/auth/otp/send-sign-in-code/rou…

0bcafcd

…te.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update apps/backend/prisma/seed.ts

15f73de

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Merge branch 'dev' into remove-old-config

8c18c7f

fix

073ab15

fix tests

bc069b0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove legacy tenancy config #802

Remove legacy tenancy config #802

fomalhautb commented Jul 24, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

vercel bot commented Jul 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

recurseml bot commented Jul 24, 2025

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Remove legacy tenancy config #802

Are you sure you want to change the base?

Remove legacy tenancy config #802

Conversation

fomalhautb commented Jul 24, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

recurseml bot commented Jul 24, 2025

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Greptile Summary

Confidence score: 3/5

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fomalhautb commented Jul 24, 2025 •

edited by ellipsis-dev bot

Loading

vercel bot commented Jul 24, 2025 •

edited

Loading