Log line cleanup: SparMetric to SparkMetric
#397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@turtlemonvh Thank you for contributing the fix. Would you mind signing-off the commit ( |
smola
approved these changes
Jul 18, 2018
Contributor
|
@ajnavarro Note that we got confirmation that no DCO is ok for typo fixing, so we can merge this if it passes CI. |
Noticed this while reading through your code. Signed-off-by: timothy <timothy@ionicsecurity.com>
Contributor
Author
|
Sorry I missed your comment before @smola . I had just submitted the pr through the github's UI and never had the code cloned locally. But I signed the request, merged to update the branch, and rebased to clean up history so it should be gtg now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while reading through your code.