这是indexloc提供的服务，不要输入任何密码
Skip to content

Change log level for closing repository message #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2018
Merged

Change log level for closing repository message #391

merged 1 commit into from
May 8, 2018

Conversation

@smacker
Copy link
Contributor

@smacker smacker commented May 7, 2018

After https://github.com/src-d/engine/pull/380/files we call close() method on TaskCompletion and also call it on destroyObject. It causes unnecessary warnings. According to code, it expected behavior now and shouldn't be a warning.

Steps to reproduce:

> import tech.sourced.engine._
> val engine = Engine(spark, "/Users/smacker/Work/gemini/src/test/resources/siva", "siva")
> val r = engine.getRepositories.getHEAD.getCommits.getTreeEntries.getBlobs.filter('is_binary === false).cache()
> r.show()

18/05/07 12:59:14 WARN RepositoryProvider: closing repository at /private/var/folders/qq/2hysx6wj34d040mcby284j300000gn/T/spark-bb7cd59a-8173-4dc9-8436-077b3ae6c794/processing-repositories/E4236CDEBF2574B13D4381645209F7B8/2636f3c62f1a407b2996da6e3fe6fdc5d1ccd764.siva; returning object to the pool failed because it was already returned

@smacker
Change log level for closing repository message
a96d8fc 
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
@smacker smacker mentioned this pull request May 7, 2018
Closed
@ajnavarro ajnavarro merged commit e8a222f into src-d:master May 8, 2018
@bzz
Copy link
Contributor

bzz commented May 18, 2018 •
edited
Loading

@ajnavarro by any chance, is there an option to cut an Engine release with this fix please? So applications, that depend on it could benefit.

AFAIK latest release 0.6.1 is 21 days ago and does not include this.

Thanks in advance!

@bzz
Copy link
Contributor

bzz commented May 18, 2018

https://github.com/src-d/engine/releases/tag/v0.6.2 has just been release 🎉 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcarmonaa mcarmonaa Awaiting requested review from mcarmonaa

@erizocosmico erizocosmico Awaiting requested review from erizocosmico

1 more reviewer

@ajnavarro ajnavarro ajnavarro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smacker @bzz @ajnavarro