add support for Apache Spark 2.3 #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ideally we would add a test build on Travis with Spark 2.3.x. |
ajnavarro
reviewed
Jun 18, 2018
Contributor
ajnavarro
left a comment
There was a problem hiding this comment.
I would prefer to add travis 2.3.x execution on this PR too.
|
|
||
| def apply[T](s22: T, s23: T): T = SPARK_VERSION match { | ||
| case s if s.startsWith("2.2.") => s22 | ||
| case s if s.startsWith("2.3.") => s23 |
Contributor
There was a problem hiding this comment.
Should we use complete versions? I think we needed to change some internal call to move from 2.2.0 to 2.2.1
Contributor
There was a problem hiding this comment.
nevermind, It was moving from 2.1.x to 2.2.x
Contributor
Author
|
@ajnavarro 👍 Let's not merge this until proper CI is in place. |
Contributor
|
Great! Just sharing, in case this example of CI from Gemini, that can be used with different Spark versions could help here. |
- A new private package `compat` is added with compatibility shims. - Shims for apply/unapply on LogicalRelation are added with compatibility with Spark 2.2.x and 2.3.x. - If an unsupported Spark version is used, a human-readable exception is thrown. Signed-off-by: Santiago M. Mola <santiago@sourced.tech>
- Test Apache Spark 2.2.1 and 2.3.1 on Travis. - Use stage builds. Signed-off-by: Santiago M. Mola <santiago@sourced.tech>
Contributor
Author
|
Added CI (migrated to Travis Build Stages). |
ajnavarro
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new private package
compatis added with compatibility shims.Shims for apply/unapply on LogicalRelation are added with compatibility
with Spark 2.2.x and 2.3.x.
If an unsupported Spark version is used, a human-readable exception is thrown.