closing session of each call #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
1 similar comment
|
+1 |
Owner
|
Makes sense to me, but it may not be desirable to close the session, for example, if a session object was provided when creating the AsyncRequest object. As a possible solution to your problem, you could create a session object and pass that same session object in for all your requests. That way, you should take advantage of the connection pooling of the one session, rather than opening a new connection for each request. Unless I'm missing something here, but I'm going to close for now, since this has been open for a while without activity. Feel free to reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
I've try to use grequests but the sessions wasn't close so my HA proxy was laggy...
I've solved the problem by closing the session in a finally. The tests pass in my env.
Maybe there is other solutions to this problem.
Regards,
Adrien