request may not have attr exception #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you for this contribution @Germey and apologies for the very long delay in getting this addressed. This makes perfect sense to me. If there is no response, clearly it's an exceptional case and the exception handler should have an opportunity to handle it, even if the I'll go ahead and merge this in and release a new version Though, I am curious if you have any example of how the issue can be reproduced so that tests can be added. Thanks again! |
Contributor
Author
|
Thanks for your merging. But I forgot the example because of so long time. If I have similar case, I'll send it back to you. Hopes well, Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestmay not have attr exception, I've tested for many times.if
requestdoesn't have exception attr, it will not call exception_handler, and at this time, response is none, so you don't know where to handle this situation.So although
requestdoesn't have exception attr, you can still call exception handler, so you can handle this situation by judgeingrequest's attrs.