Adding DBI methods #3296
Merged
Adding DBI methods #3296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added the support for the I've created dedicated unit-tests and locally evaluated with success the This work is performed in order to use Is there something else needed to be compliant with the contribution process ? |
…mments Signed-off-by: Ali <contact@alibellamine.me>
Signed-off-by: Ali <contact@alibellamine.me>
Signed-off-by: Ali <contact@alibellamine.me>
Signed-off-by: Ali <contact@alibellamine.me>
Signed-off-by: Ali <contact@alibellamine.me>
Signed-off-by: Ali <contact@alibellamine.me>
Signed-off-by: Ali <contact@alibellamine.me>
Signed-off-by: Ali <contact@alibellamine.me>
Signed-off-by: Ali <contact@alibellamine.me>
…riteTable Signed-off-by: Ali <contact@alibellamine.me>
Signed-off-by: Ali <contact@alibellamine.me>
Signed-off-by: Ali <contact@alibellamine.me>
Signed-off-by: Ali <contact@alibellamine.me>
Signed-off-by: Ali <contact@alibellamine.me>
Signed-off-by: Ali <contact@alibellamine.me>
Signed-off-by: Ali <contact@alibellamine.me>
Signed-off-by: Ali <contact@alibellamine.me>
|
Hi Ali, thank you so much for this PR. I'll be reviewing it shortly. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I submit this proposal of pull request on Sparklyr project.
The main idea is to add some DBI methods and a tiny changes.
New methods:
dbIsValiddbDisconnectChanges:
dbWriteTable:dbListTables:I am mainly motivated because of my use of a library that rely on DBI methods. The absence of these methods breaks the compatibility with this library.
Thank you,
Ali Bellamine